Bump aioswitcher to 3.4.1

[YogevBokobza]

Bump aioswitcher to 3.4.1

GitHub diff: TomerFi/aioswitcher@3.3.0...3.4.1
Release notes: https://github.com/TomerFi/aioswitcher/releases/tag/3.4.1

Breaking change

Proposed change

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes Switch not working #100955
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @thecode, mind taking a look at this pull request as it has been labeled with an integration (switcher_kis) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of switcher_kis can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign switcher_kis Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[thecode]

Please address the following:

• Failing CI tests (I highly recommend setting up Development Environment and run there the tests and pre-commit.
• PR description example for a dependency bump: Bump aioswitcher to 3.1.0 #80534, review which checks apply and mark them in the checklist
• PR example for a bugfix: Bump aioswitcher to 3.3.0 #91215 which also apply in this case since this is a bugfix

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[thecode]

You need to update the mocked devices at:
https://github.com/home-assistant/core/blob/dev/tests/components/switcher_kis/consts.py
to include the device_key

[YogevBokobza]

You need to update the mocked devices at: https://github.com/home-assistant/core/blob/dev/tests/components/switcher_kis/consts.py to include the device_key

I updated the file you mentioned. Do need an update in test_X files on the same path?

[YogevBokobza]

@thecode Any idea why the only 2 tests failed? I cant understand why from the log..

[thecode]

Thanks @YogevBokobza 👍

[thecode]

Tips for next PRs:

• You can include list of devices you tested the changes on so others can know which devices needs testing (I tested this PR before approving on Switcher Touch and Switcher Plug)
• Please check if there are open bugs related to the bugfix (I edited your PR comment and linked to the relevant bug)
• You can ask to add a PR to the next milestone (for this PR it will be 2024.1.3), only bugfixes are accepted, PRs which include new functionality needs to go to dev first and wait for next major release.
• I suggest again to install Development Environment in the dev container you have built in task to run tests & coverage (which will take ~30seconds instead of here you have to wait 45minutes) and it has all the linting & check tools used by the CI that runs when you commit changes locally.

Thanks for finding & fixing this issue.

[YogevBokobza]

• You can ask to add a PR to the next milestone (for this PR it will be 2024.1.3), only bugfixes are accepted, PRs which include new functionality needs to go to dev first and wait for next major release.

Thanks for the tips!

You can ask to add a PR to the next milestone (for this PR it will be 2024.1.3), only bugfixes are accepted, PRs which include new functionality needs to go to dev first and wait for next major release.

How to do that ?