Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aioswitcher to 3.3.0 #91215

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Bump aioswitcher to 3.3.0 #91215

merged 1 commit into from
Apr 11, 2023

Conversation

regevbr
Copy link
Contributor

@regevbr regevbr commented Apr 11, 2023

Breaking change

Proposed change

Upgrade aioswitcher to 3.3.0 which fixes issue :#85096

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @TomerFi, @thecode, mind taking a look at this pull request as it has been labeled with an integration (switcher_kis) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of switcher_kis can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign switcher_kis Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@TomerFi
Copy link
Contributor

TomerFi commented Apr 11, 2023

LGTM

@epenet epenet changed the title fix: #85096 Switcher "No devices found on the network" Bump aioswitcher to 3.3.0 Apr 11, 2023
@epenet epenet added this to the 2023.4.3 milestone Apr 11, 2023
@epenet
Copy link
Contributor

epenet commented Apr 11, 2023

I assume this is wanted for the next patch release.

@regevbr
Copy link
Contributor Author

regevbr commented Apr 11, 2023

I assume this is wanted for the next patch release.

yes please

@balloob balloob merged commit d14e969 into home-assistant:dev Apr 11, 2023
@regevbr regevbr deleted the switcher branch April 11, 2023 13:25
@thecode thecode removed this from the 2023.4.3 milestone Apr 11, 2023
@thecode
Copy link
Member

thecode commented Apr 11, 2023

I have removed this from the milestone, since my previous testing with adding port 10002 to the integration created an error with the port already occupied (probably a conflict with another integration).
It would be better to let it go through normal beta testing. I don't have devices with this firmware to test it myself.

@regevbr please create a PR to update the port in the docs: https://www.home-assistant.io/integrations/switcher_kis/#notes

@regevbr
Copy link
Contributor Author

regevbr commented Apr 11, 2023

Sure will do

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switcher "No devices found on the network"
5 participants