-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing dependencies #108070
Add missing dependencies #108070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
# Ensure we run compatible with musllinux build env | ||
"numpy==1.26.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
numpy is a dependency of multiple integrations, but not directly of core itself?
Where is this used otherwise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stream
is using numpy. I also experienced this when setting up a new dev env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, but integration dependencies are set up when those integrations set up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes and no, pre-commit needs them for some reason. I haven't really looked into it as I could fix it, but its an issue reported multiple times
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, before the dev environment works completely, you need to start hass -c config
once and the default_config entry has to be in the configuration.yaml, so that all dependencies get set up.
@@ -41,6 +41,9 @@ dependencies = [ | |||
"ifaddr==0.2.0", | |||
"Jinja2==3.1.2", | |||
"lru-dict==1.3.0", | |||
"mutagen==1.47.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mutagen is a dependency of TTS not core itself? Where is this used otherwise?
@@ -49,6 +52,7 @@ dependencies = [ | |||
"orjson==3.9.10", | |||
"packaging>=23.1", | |||
"pip>=21.3.1", | |||
"python-dateutil==2.8.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use dateutil in our core? This seems/sounds like an integration dependency?
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Breaking change
None
Proposed change
When I follow Installation for linux and after I run
hass
, the output print python module was missing. And after try 3 times (rm -rf /home/homeassistant/.homeassistant), I finally installed all the dependences which arenumpy
,mutagen
andpython-dateutil
.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: