Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiounifi to v71 #110658

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Bump aiounifi to v71 #110658

merged 1 commit into from
Feb 15, 2024

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Feb 15, 2024

Breaking change

Proposed change

Three minor fixes in library Kane610/aiounifi@v70...v71

  1. Fix new messages previously unsupported by the library
  2. Improve speed by using 'is' on enums rather than '=='
  3. Catch a json decode error that breaks websocket connection

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck frenck merged commit dc09633 into home-assistant:dev Feb 15, 2024
53 checks passed
@Kane610 Kane610 deleted the unifi-bump_to_v71 branch February 15, 2024 18:44
@Kane610
Copy link
Member Author

Kane610 commented Feb 15, 2024

Thanks 🎉

frenck pushed a commit that referenced this pull request Feb 16, 2024
@frenck frenck mentioned this pull request Feb 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants