Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add title to reauthenticate integration issue #111275

Merged
merged 5 commits into from Feb 26, 2024
Merged

Add title to reauthenticate integration issue #111275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d0927da
Add title to reauthenticate integration issue
timmo001 Feb 24, 2024
5d93b09
Fix translation placeholder in test
timmo001 Feb 24, 2024
bb7313e
Update translation placeholders in test_init.py
timmo001 Feb 24, 2024
603a677
Update integration reauthentication message
timmo001 Feb 24, 2024
e4659d0
Update string
timmo001 Feb 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions homeassistant/config_entries.py
View file
Open in desktop
Expand Up @@ -891,6 +891,7 @@ async def _async_init_reauth(
issue_domain=self.domain,
severity=ir.IssueSeverity.ERROR,
translation_key="config_entry_reauth",
translation_placeholders={"name": self.title},
)

@callback
Expand Down
2 changes: 1 addition & 1 deletion homeassistant/strings.json
View file
Open in desktop
Expand Up @@ -68,7 +68,7 @@
"config_flow": {
"title": {
"oauth2_pick_implementation": "Pick authentication method",
"reauth": "Reauthenticate integration",
"reauth": "Authentication expired for {name}",
"via_hassio_addon": "{name} via Home Assistant add-on"
},
"description": {
Expand Down
4 changes: 2 additions & 2 deletions tests/components/kitchen_sink/test_init.py
View file
Open in desktop
Expand Up @@ -205,7 +205,7 @@ async def test_issues_created(
"learn_more_url": None,
"severity": "error",
"translation_key": "config_entry_reauth",
"translation_placeholders": None,
"translation_placeholders": {"name": "Kitchen Sink"},
"ignored": False,
},
]
Expand Down Expand Up @@ -322,7 +322,7 @@ async def test_issues_created(
"learn_more_url": None,
"severity": "error",
"translation_key": "config_entry_reauth",
"translation_placeholders": None,
"translation_placeholders": {"name": "Kitchen Sink"},
"ignored": False,
},
]
Expand Down
2 changes: 1 addition & 1 deletion tests/test_config_entries.py
View file
Open in desktop
Expand Up @@ -1044,7 +1044,7 @@ async def test_reauth_issue(hass: HomeAssistant) -> None:
learn_more_url=None,
severity=ir.IssueSeverity.ERROR,
translation_key="config_entry_reauth",
translation_placeholders=None,
translation_placeholders={"name": "test_title"},
)

result = await hass.config_entries.flow.async_configure(issue.data["flow_id"], {})
Expand Down