Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title to reauthenticate integration issue #111275

Merged
merged 5 commits into from Feb 26, 2024

Conversation

timmo001
Copy link
Contributor

@timmo001 timmo001 commented Feb 24, 2024

Proposed change

The current issue title doesn't give context to what service/device needs reauthentication like the integration dashboard. This adds the title to the issue name, so that context is provided.

Type of change

  • New feature (which adds functionality to an existing integration)

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed core new-feature small-pr PRs with less than 30 lines. labels Feb 24, 2024
@timmo001 timmo001 force-pushed the reauthenticate-title branch 3 times, most recently from a0741bf to 06d0c1b Compare February 24, 2024 15:41
@timmo001 timmo001 marked this pull request as ready for review February 24, 2024 16:52
@timmo001 timmo001 requested a review from a team as a code owner February 24, 2024 16:52
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's think of a better sentence

homeassistant/strings.json Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft February 24, 2024 21:28
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@timmo001 timmo001 marked this pull request as ready for review February 24, 2024 21:50
@balloob balloob merged commit 9f77e27 into home-assistant:dev Feb 26, 2024
53 checks passed
@timmo001 timmo001 deleted the reauthenticate-title branch February 26, 2024 14:26
@akloeckner
Copy link
Contributor

akloeckner commented Feb 26, 2024

I just tried to trace what changed between 2024.2.3 and 2024.2.4, because I'm seeing the same warnings as in #111621, #111561, #111562 and #111516. And the only thing I could find is this PR. Hence this post to mark those as possibly related and maybe draw some atttention to the right places.

@corporategoth
Copy link

I am getting this bug reported to my repo too. Complaining about a missing placeholder in the component.homeassistant.issues.config_entry_reauth.title token. Which I assume is {name}, but this was not broken before 2024.2.4.

@balloob balloob added this to the 2024.2.5 milestone Feb 27, 2024
balloob pushed a commit that referenced this pull request Feb 27, 2024
* Add title to reauthenticate integration issue

* Fix translation placeholder in test

* Update translation placeholders in test_init.py

* Update integration reauthentication message

* Update string
@balloob balloob mentioned this pull request Feb 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants