Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostic platform to Whirlpool #114578

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Conversation

mkmer
Copy link
Contributor

@mkmer mkmer commented Apr 1, 2024

Proposed change

Add diagnostic platform to Whirlpool
Add tests for diagnostic platform

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Apr 1, 2024

Hey there @abmantis, mind taking a look at this pull request as it has been labeled with an integration (whirlpool) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of whirlpool can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign whirlpool Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@lboue
Copy link
Contributor

lboue commented Apr 1, 2024

@mkmer
Can you tell us which device models this applies to?

@mkmer
Copy link
Contributor Author

mkmer commented Apr 1, 2024

@lboue - I don't under stand the question: which device models? It (the API) supports washer/dryer, air conditioners, and ovens. Maybe abmantis knows models?
I'm adding the diagnostics to dump all devices supported by the whirlpool integration. I only noticed today, when trying to debug login issues, that we didn't have diagnostics in the integration.

Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @mkmer 👍

@jpbede jpbede merged commit 078535e into home-assistant:dev Apr 2, 2024
21 checks passed
@lboue
Copy link
Contributor

lboue commented Apr 2, 2024

@lboue - I don't under stand the question: which device models? It supports washer/dryer, air conditioners, and ovens. Maybe abmantis knows models? I'm adding the diagnostics to dump all devices supported by the whirlpool integration.

Thanks for the explanation.

@joostlek joostlek added this to the 2024.4.0 milestone Apr 2, 2024
@joostlek
Copy link
Member

joostlek commented Apr 2, 2024

I'll tag it for the beta to be able so you don't have to wait a release cycle to debug your issue

frenck pushed a commit that referenced this pull request Apr 2, 2024
* Add diagnostic platform and tests

* lowercase variable

* Correc doc string
@mkmer mkmer deleted the Whirlpool-diag branch April 2, 2024 11:01
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants