-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diagnostic platform to Whirlpool #114578
Conversation
Hey there @abmantis, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@mkmer |
@lboue - I don't under stand the question: which device models? It (the API) supports washer/dryer, air conditioners, and ovens. Maybe abmantis knows models? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @mkmer 👍
Thanks for the explanation. |
I'll tag it for the beta to be able so you don't have to wait a release cycle to debug your issue |
* Add diagnostic platform and tests * lowercase variable * Correc doc string
Proposed change
Add diagnostic platform to Whirlpool
Add tests for diagnostic platform
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: