-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump py-synologydsm-api to 2.4.2 #115499
Bump py-synologydsm-api to 2.4.2 #115499
Conversation
Hey there @hacf-fr, @Quentame, @mib1185, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
unfortunately, the added typing in 2.2.0 (mib1185/py-synologydsm-api#183) blocks a simple bump of this lib (already tried in the past in #92092) ... i'm already working on some tweaks in typing of the lib, so a 2.4.1 is coming very soon |
Retested cameras since it needs a functional change as the type was wrong. Still works the same |
still need to test reboot works |
needs explicit relogin now
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks @bdraco 👍
Thanks for the quick fixes 👍 |
Proposed change
changelog: mib1185/py-synologydsm-api@v2.1.4...v2.4.2
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: