Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump py-synologydsm-api to 2.4.2 #115499

Merged
merged 18 commits into from
Apr 13, 2024
Merged

Bump py-synologydsm-api to 2.4.2 #115499

merged 18 commits into from
Apr 13, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 12, 2024

Proposed change

changelog: mib1185/py-synologydsm-api@v2.1.4...v2.4.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @hacf-fr, @Quentame, @mib1185, mind taking a look at this pull request as it has been labeled with an integration (synology_dsm) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of synology_dsm can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign synology_dsm Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@mib1185
Copy link
Contributor

mib1185 commented Apr 12, 2024

unfortunately, the added typing in 2.2.0 (mib1185/py-synologydsm-api#183) blocks a simple bump of this lib (already tried in the past in #92092) ... i'm already working on some tweaks in typing of the lib, so a 2.4.1 is coming very soon

@mib1185
Copy link
Contributor

mib1185 commented Apr 12, 2024

@bdraco bdraco changed the title Bump py-synologydsm-api to 2.4.0 Bump py-synologydsm-api to 2.4.1 Apr 12, 2024
@bdraco
Copy link
Member Author

bdraco commented Apr 12, 2024

Retested cameras since it needs a functional change as the type was wrong. Still works the same

@bdraco
Copy link
Member Author

bdraco commented Apr 12, 2024

still need to test reboot works

@bdraco
Copy link
Member Author

bdraco commented Apr 12, 2024

needs explicit relogin now

2024-04-12 17:49:01.174 DEBUG (MainThread) [homeassistant.components.synology_dsm.common] Start data update for '2040SBRZJVHSE'
2024-04-12 17:49:01.175 ERROR (MainThread) [homeassistant.components.synology_dsm.coordinator] Unexpected error fetching 192.168.208.5 SynologyDSMCentralUpdateCoordinator data
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 315, in _async_refresh
    self.data = await self._async_update_data()
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/synology_dsm/coordinator.py", line 104, in _async_update_data
    await self.api.async_update()
  File "/usr/src/homeassistant/homeassistant/components/synology_dsm/common.py", line 299, in async_update
    await self._update()
  File "/usr/src/homeassistant/homeassistant/components/synology_dsm/common.py", line 305, in _update
    await self.dsm.update(self._with_information)
  File "/usr/local/lib/python3.11/site-packages/synology_dsm/synology_dsm.py", line 437, in update
    await asyncio.gather(*update_methods)
  File "/usr/local/lib/python3.11/site-packages/synology_dsm/api/dsm/information.py", line 30, in update
    raw_data = await self._dsm.get(self.API_KEY, "getinfo")
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/synology_dsm/synology_dsm.py", line 238, in get
    return await self._request("GET", api, method, params, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/synology_dsm/synology_dsm.py", line 310, in _request
    url, params, kwargs = await self._prepare_request(api, method, params, **kwargs)
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/synology_dsm/synology_dsm.py", line 270, in _prepare_request
    raise SynologyDSMNotLoggedInException
synology_dsm.exceptions.SynologyDSMNotLoggedInException: {'api': None, 'code': -1, 'reason': 'Unknown', 'details': 'Not logged in. You have to do login() first.'}

@mib1185 mib1185 changed the title Bump py-synologydsm-api to 2.4.1 Bump py-synologydsm-api to 2.4.2 Apr 13, 2024
@mib1185 mib1185 marked this pull request as ready for review April 13, 2024 08:50
@mib1185 mib1185 requested a review from Quentame as a code owner April 13, 2024 08:50
Copy link
Contributor

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @bdraco 👍

@bdraco
Copy link
Member Author

bdraco commented Apr 13, 2024

Thanks for the quick fixes 👍

@bdraco bdraco merged commit 008c42e into dev Apr 13, 2024
38 checks passed
@bdraco bdraco deleted the syno_speed_up branch April 13, 2024 19:38
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants