Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce type annotations #183

Merged
merged 18 commits into from
Feb 19, 2023
Merged

Introduce type annotations #183

merged 18 commits into from
Feb 19, 2023

Conversation

mib1185
Copy link
Owner

@mib1185 mib1185 commented Sep 19, 2022 •
edited

start with type annotations within the core of this lib

api specific modules

  • core
  • download_station
  • dsm
  • photos
  • storage
  • surveillance_station

@mib1185 mib1185 marked this pull request as draft September 19, 2022 19:32
@mib1185 mib1185 added this to the 2.1.0 milestone Jan 15, 2023
@mib1185 mib1185 mentioned this pull request Jan 15, 2023
Merged
@mib1185 mib1185 modified the milestones: 2.1.0, 2.2.0 Jan 29, 2023
@mib1185 mib1185 marked this pull request as ready for review January 29, 2023 14:24
@mib1185 mib1185 changed the title add type hints Add type hints Jan 29, 2023
@mib1185 mib1185 changed the title Add type hints Introduce mypy checks Jan 29, 2023
@mib1185 mib1185 changed the title Introduce mypy checks Introduce type annotations within the core modules Jan 29, 2023
@mib1185 mib1185 changed the title Introduce type annotations within the core modules Introduce type annotations within the base module Jan 29, 2023
@mib1185 mib1185 added build PR that updates build utils code_quality labels Jan 29, 2023
@mib1185 mib1185 mentioned this pull request Jan 29, 2023
Closed
@mib1185 mib1185 changed the title Introduce type annotations within the base module Introduce type annotations Jan 29, 2023
@mib1185 mib1185 force-pushed the add-type-hints branch 2 times, most recently from 301f9ae to 4d7d2d8 Compare January 29, 2023 17:55
@bdraco
Copy link
Contributor

bdraco commented Jan 30, 2023

Also don't forget to add a py.typed file https://peps.python.org/pep-0561/

@mib1185 mib1185 merged commit b9c55a5 into master Feb 19, 2023
@mib1185 mib1185 deleted the add-type-hints branch February 19, 2023 19:56
@mib1185 mib1185 removed the build PR that updates build utils label Feb 19, 2023
@mib1185 mib1185 mentioned this pull request Feb 25, 2023
Merged
@mib1185 mib1185 mentioned this pull request Apr 26, 2023
Closed
20 tasks
@mib1185 mib1185 mentioned this pull request Apr 12, 2024
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdraco bdraco bdraco left review comments

Assignees
No one assigned
Labels
code_quality
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mib1185 @bdraco