Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always do thread safety checks when calling async_fire #116055

Merged
merged 30 commits into from
Apr 24, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 23, 2024

needs

Proposed change

Since almost all core events call async_fire_internal (after #116027) now its worth the performance tradeoff to check if the thread is correct in async_fire.

See discussion #115390 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

homeassistant/core.py Outdated Show resolved Hide resolved
Since almost all core events call async_fire_internal now
its worth the performance tradeoff here to check
if the thread is correct
@bdraco bdraco force-pushed the debug_mode_poc_async_fire_event branch from a2818d3 to 4a8a6a3 Compare April 23, 2024 19:27
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a merge conflict.

homeassistant/core.py Outdated Show resolved Hide resolved
homeassistant/core.py Outdated Show resolved Hide resolved
@bdraco bdraco marked this pull request as ready for review April 24, 2024 04:05
@bdraco bdraco requested a review from a team as a code owner April 24, 2024 04:05
@bdraco bdraco merged commit 4a59ee9 into dev Apr 24, 2024
38 checks passed
@bdraco bdraco deleted the debug_mode_poc_async_fire_event branch April 24, 2024 04:41
@bdraco
Copy link
Member Author

bdraco commented Apr 24, 2024

In a followup I will add the check in async_register and async_unregister and switch them to use _internal since currently they can still unsafely register a service from a thread since the check doesn't happen until the service registered event is fired. It will also give devs a better hint as to where things went wrong

@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants