-
-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for animal detection in unifiprotect #116290
Add support for animal detection in unifiprotect #116290
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Hey there @AngellusMortis, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
I updated to the latest home assistant but do not see the animal detections? I have Home Assistant OS installed and just use the default unifi protect plugin for my UNVR Pro. Is this correct? I can see person, object, and vehicle detection. I have a slew of G4 Pros and G5 Cameras. Thanks in advance |
@josephdc18 this has not been merged into the core integration yet, as you can see by the open status. If you would like to test it out for yourself you will need to grab a copy of the files from fork wfltaylor:unifiprotect-animal-detection and put them in your custom_components (make sure there's a version specified in manifest.json) to override it. |
thanks so much for this @wfltaylor , do we know when this will be merged? currently found this https://developers.home-assistant.io/docs/creating_integration_manifest/ |
Looks good. I don't think there are any docs changes needed but will need to review https://www.home-assistant.io/integrations/unifiprotect/ to check. |
I'll try to test this sometime this week. June is super busy for me to it might not be until next week but shouldn't be a problem to get merged before 2024.7 |
It looks like the tests are failing, please check. Thanks! |
As pointed out above, the test are failing, could you take a look @wfltaylor? I've marked the PR as draft, please mark it ready for review once the issue has been addressed. Thanks! 👍 ../Frenck |
34713a8
to
c000c74
Compare
codecov seems to be ratelimited right now. I'll try again in a bit |
checked coverage locally.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wfltaylor
Proposed change
This adds support for smart animal detection already supported by pyunifiprotect. As with the other smart detections, this is exposed as binary sensor and a switch to control whether the detection is enabled.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: