Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add select entities to AirGradient #117136

Merged
merged 8 commits into from
May 29, 2024
Merged

Conversation

joostlek
Copy link
Member

@joostlek joostlek commented May 9, 2024

Proposed change

Add select entities to AirGradient

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented May 9, 2024

Hey there @airgradienthq, mind taking a look at this pull request as it has been labeled with an integration (airgradient) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of airgradient can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign airgradient Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@edenhaus
Copy link
Contributor

@coderabbitai review

Copy link

coderabbitai bot commented May 24, 2024

Actions Performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link

coderabbitai bot commented May 24, 2024

Walkthrough

The recent updates to the AirGradient integration within Home Assistant involve a comprehensive refactor to improve the setup and data handling processes. Key changes include the introduction of specialized coordinators for configuration and measurement, the utilization of an AirGradientClient for API interactions, and the addition of select entities to manage configuration settings. These modifications enhance device registration, streamline data updates, and expand the integration's functionality.

Changes

Files/Paths Change Summaries
homeassistant/components/airgradient/__init__.py Refactored setup process, introduced AirGradientClient, added AirGradientConfigCoordinator and AirGradientMeasurementCoordinator, enhanced device registration, and updated platform types.
homeassistant/components/airgradient/coordinator.py Refactored AirGradientDataUpdateCoordinator into AirGradientCoordinator, and split it into AirGradientMeasurementCoordinator and AirGradientConfigCoordinator for specific data updates.
homeassistant/components/airgradient/entity.py Updated AirGradientEntity to use AirGradientCoordinator, simplified DeviceInfo initialization.
homeassistant/components/airgradient/select.py Introduced support for select entities, added AirGradientSelectEntityDescription, AirGradientSelect, and AirGradientProtectedSelect classes, and setup functions.
homeassistant/components/airgradient/sensor.py Replaced AirGradientDataUpdateCoordinator with AirGradientMeasurementCoordinator, updated setup and initialization processes.
homeassistant/components/airgradient/strings.json Added new configurations for "Configuration source" and "Display temperature unit", and an exception message for "no_local_configuration".
tests/components/airgradient/conftest.py Updated imports, adjusted mock setup for AirGradientClient, added host setting and configuration data return.
tests/components/airgradient/fixtures/get_config.json Defined configuration settings for air quality monitoring.
tests/components/airgradient/snapshots/test_select.ambr Added snapshots for select entities capturing their attributes, states, and metadata for testing.
tests/components/airgradient/test_select.py Added tests for AirGradient select platform, including setting values and handling protected values.
tests/components/airgradient/test_sensor.py Updated imports, and patched PLATFORMS during setup for testing.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@joostlek joostlek marked this pull request as ready for review May 29, 2024 16:40
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joostlek 👍

@edenhaus edenhaus merged commit c807186 into home-assistant:dev May 29, 2024
24 checks passed
@joostlek joostlek deleted the ag-select branch May 29, 2024 18:13
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants