-
-
Notifications
You must be signed in to change notification settings - Fork 28.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unique_id not being unique in HomeWizard #117940
Conversation
Whow wait.. |
So, because I've inserted the test fixtures in I've reordered the parameters and it is now okay-ish. Sorry for not spotting this! |
d87dcbb
to
aa5be63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks, @DCSBL 👍
../Frenck
Thanks Frenck! |
Proposed change
Migrate
unique_id
of externally connected device (e.g. Gas meter connected to smart meter) fromhomewizard_<EAN>
tohomewizard_<type>_<EAN>
. This make is less likely that an user has two device with same unique ID.EAN should be unique, but due to an issue at Fluvius the may be all zeros. This triggers issue #117557.
Bumbs python-homewizard-energy to v6.0.0:
Closes #117557
I think we are not in a hurry, so we can add this in 2024.6. This also helps us testing the migration and to see if this issue is actually fixed for the end user, I can only mock data.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: