Remove deprecated services from AVM Fritz!Box Tools

[mib1185]

Breaking change

The former deprecated services reboot, reconnect and cleanup has been removed. Please use the corresponding button entities instead.

Proposed change

These services has already been deprecated and superseded by button entities back in 2022 (#61483 and #63692)

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
  • Add buttons and deprecate services for Fritz #61483
  • Add button and deprecate service for Fritz cleanup #63692
• Link to documentation pull request: remove deprecated services and simplify the service section home-assistant.io#32940

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @mammuth, @AaronDavidSchneider, @chemelli74, mind taking a look at this pull request as it has been labeled with an integration (fritz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of fritz can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign fritz Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[mib1185]

@coderabbitai review

[coderabbitai]

Walkthrough

The recent updates to the Home Assistant Fritz component primarily involve refining type hints and restructuring service functionalities. The press_action attribute in FritzButtonDescription now has a more specific type hint. Additionally, deprecated services such as reboot, reconnect, and cleanup have been removed across multiple files, replaced by a new service for setting the guest Wi-Fi password. This streamlines the component's functionality and improves code clarity.

Changes

Files	Change Summary
homeassistant/components/fritz/button.py	Updated type hint for press_action in FritzButtonDescription and adjusted imports.
homeassistant/components/fritz/const.py	Removed SERVICE_REBOOT, SERVICE_RECONNECT, and SERVICE_CLEANUP; added SERVICE_SET_GUEST_WIFI_PW.
homeassistant/components/fritz/coordinator.py	Removed deprecated services and added warnings for them.
homeassistant/components/fritz/services.py	Removed declarations for deprecated services.
homeassistant/components/fritz/services.yaml	Removed deprecated services; added set_guest_wifi_password service.
homeassistant/components/fritz/strings.json	Removed deprecated services and updated field name for set_guest_wifi_password.

Tip

New Features and Improvements

Review Settings

Introduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments.

AST-based Instructions

CodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the documentation.

Community-driven AST-based Rules

We are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the ast-grep-essentials repository for more information.

New Static Analysis Tools

We are continually expanding our support for static analysis tools. We have added support for biome, hadolint, and ast-grep. Update the settings in your .coderabbit.yaml file or head over to the settings page to enable or disable the tools you want to use.

Tone Settings

Users can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples:

• Mr. T: "You must talk like Mr. T in all your code reviews. I pity the fool who doesn't!"
• Pirate: "Arr, matey! Ye must talk like a pirate in all yer code reviews. Yarrr!"
• Snarky: "You must be snarky in all your code reviews. Snark, snark, snark!"

Revamped Settings Page

We have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to .coderabbit.yaml will be reflected in the settings page, and vice versa.

Miscellaneous

• Turn off free summarization: You can switch off free summarization of PRs opened by users not on a paid plan using the enable_free_tier setting.
• Knowledge-base scope: You can now set the scope of the knowledge base to either the repository (local) or the organization (global) level using the knowledge_base setting. In addition, you can specify Jira project keys and Linear team keys to limit the knowledge base scope for those integrations.
• High-level summary placement: You can now customize the location of the high-level summary in the PR description using the high_level_summary_placeholder setting (default @coderabbitai summary).
• Revamped request changes workflow: You can now configure CodeRabbit to auto-approve or request changes on PRs based on the review feedback using the request_changes_workflow setting.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 10efb20 and 39deeb6.

Files selected for processing (6)

• homeassistant/components/fritz/button.py (2 hunks)
• homeassistant/components/fritz/const.py (1 hunks)
• homeassistant/components/fritz/coordinator.py (2 hunks)
• homeassistant/components/fritz/services.py (2 hunks)
• homeassistant/components/fritz/services.yaml (1 hunks)
• homeassistant/components/fritz/strings.json (1 hunks)

Files skipped from review due to trivial changes (1)

• homeassistant/components/fritz/coordinator.py

Additional comments not posted (5)

homeassistant/components/fritz/services.yaml (1)

Line range hint 1-14: The new service definition for set_guest_wifi_password is well-defined and aligns with the integration's standards.

homeassistant/components/fritz/const.py (1)

Line range hint 47-47: The addition of SERVICE_SET_GUEST_WIFI_PW is correctly implemented and necessary for the new service functionality.

homeassistant/components/fritz/services.py (1)

14-14: The implementation of the new service set_guest_wifi_password is correct and well-integrated within the Fritz services setup.

Also applies to: 28-28

homeassistant/components/fritz/strings.json (1)

152-152: The localization strings for the set_guest_wifi_password service are clear and appropriately describe the service's functionality.

homeassistant/components/fritz/button.py (1)

33-33: The type refinement for press_action in FritzButtonDescription enhances clarity and correctness, ensuring the attribute matches the expected callable signature.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[frenck]

Thanks, @mib1185 👍

../Frenck