Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buttons and deprecate services for Fritz #61483

Merged
merged 3 commits into from
Dec 16, 2021

Conversation

chemelli74
Copy link
Contributor

@chemelli74 chemelli74 commented Dec 11, 2021

Proposed change

  • add "reboot", "reconnect", "firmware update" buttons
  • log warning if "reboot" or "reconnect" services are used

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @mammuth, @AaronDavidSchneider, mind taking a look at this pull request as it has been labeled with an integration (fritz) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Contributor

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chemelli74 chemelli74 merged commit 105ad86 into home-assistant:dev Dec 16, 2021
@chemelli74 chemelli74 deleted the chemelli74-fritz-buttons branch December 16, 2021 13:15
@frenck
Copy link
Member

frenck commented Dec 16, 2021

This PR is missing the a matching documentation PR to clean up the deprecated services from the documentation. @mib1185 Please make sure you check if the docs are up to date when e.g., services change :)

@chemelli74 Could you please open a PR for that?

@mib1185
Copy link
Contributor

mib1185 commented Dec 17, 2021

@mib1185 Please make sure you check if the docs are up to date when e.g., services change :)

I vow to do better 🙂

@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2021
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comment in a new PR. Thanks!

homeassistant/components/fritz/button.py Show resolved Hide resolved
@frenck
Copy link
Member

frenck commented Jan 25, 2022

This PR should have been marked as a breaking change, as this is a deprecation as well. Did it now :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants