Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nextdns to version 3.1.0 #120703

Merged
merged 4 commits into from
Jun 27, 2024
Merged

Bump nextdns to version 3.1.0 #120703

merged 4 commits into from
Jun 27, 2024

Conversation

bieniu
Copy link
Member

@bieniu bieniu commented Jun 27, 2024

Breaking change

Proposed change

I have recently noticed that the NextDNS API responds to requests with a delay or responds with a 500/503 status. This causes the entities to become unavailable. This PR fixes these problems.

It bumps nextdns to version 3.1.0 to:

  • move HTTP request timeout to backend library
  • use tenacity to retry the request when it fails

Changelog: bieniu/nextdns@3.0.0...3.1.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck frenck merged commit e764afe into home-assistant:dev Jun 27, 2024
39 checks passed
frenck pushed a commit that referenced this pull request Jun 28, 2024
Co-authored-by: Maciej Bieniek <478555+bieniu@users.noreply.github.com>
@bieniu bieniu deleted the nextdns-3.1.0 branch June 28, 2024 14:35
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants