-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config flow to Russound RIO integration #121262
Add config flow to Russound RIO integration #121262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @noahhusby
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
3e72cf5
to
3c5b6b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of thanks a lot for your contribution 🚀
Take a look at mpd
, for example, to see how you can import the existing configuration into a config entry. In this way, you avoid having a breaking change.
3c5b6b0
to
b74c591
Compare
Thought about adding the YAML importer late last night, glad you caught it too 👍 We can remove the Note: I noticed that the |
8a02b8f
to
08ec235
Compare
c21915a
to
0f2143c
Compare
0f2143c
to
a4f10cc
Compare
a4f10cc
to
d3c0ca1
Compare
Proposed change
I'm working on improving the stability of the Russound RIO integration. This is part one of a set of pull requests with feature improvements. This PR is dedicated to adding a config flow and adjacent tests to make the integration simpler to setup. I plan to add proper connection error handling, multi-instance capability, and expand the usage of the RIO protocol in coming pull requests. This includes a YAML importer for existing configurations so that this doesn't result in a breaking-change.
The config flow currently only supports a single instance (as defined in the manifest). I will be opening a PR for multi-instance support soon, but wanted to keep this PR dedicated for adding the config flow only.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: