Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify the minimum python version in the setup.py. #12144

Merged
merged 2 commits into from
Feb 7, 2018
Merged

Specify the minimum python version in the setup.py. #12144

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6f96b6
Specify the minimum python version in the setup.py.
pelson Feb 3, 2018
74c5dd7
Used the minimum python version defined in homeassistant.const.
pelson Feb 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
zip_safe=False,
platforms='any',
install_requires=REQUIRES,
python_requires=">=3.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'>=3.5.2'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Does #9328 need to be updated+closed then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can update it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think aiohttp wants 3.5.3+ as minimum for the future.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are still Python 3.4 Pascal. We're waiting till aiohttp releases v3 to bump min requirement to 3.5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this conversation, I don't think there is anything I need to do to get this PR ready.

Clearly it will be good to have the minimum python version explicitly stated in the codebase (setup.py).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already define the minimum required version in homeassistant.const, can you import it from there? We also have a different minimum version between Windows and other OSes (because of the asyncio loop that we use).

https://github.com/home-assistant/home-assistant/blob/7e246e4680d71fe9913678ede731e8c6b51aa7ae/homeassistant/const.py#L8-L9

Since we will soon align both min-versions, just sticking with 3.4.2 will do.

test_suite='tests',
keywords=['home', 'automation'],
entry_points={
Expand Down