Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello Python 3.5 #12610

Merged
merged 4 commits into from
Feb 23, 2018
Merged

Hello Python 3.5 #12610

merged 4 commits into from
Feb 23, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Feb 22, 2018

Description:

Change minimum version to Python 3.5.3

Related issue (if applicable): fixes #9328

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Checklist:

  • The code change is tested and works locally.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

Copy link
Contributor

@Julius2342 Julius2342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great!

@balloob balloob merged commit 6ee3c1b into dev Feb 23, 2018
@balloob balloob deleted the py35 branch February 23, 2018 07:22
@cdce8p cdce8p mentioned this pull request Feb 25, 2018
@balloob balloob mentioned this pull request Mar 9, 2018
@home-assistant home-assistant locked and limited conversation to collaborators May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phasing out Python 3.4 support
3 participants