Add pincode fallback #13587
Merged
Add pincode fallback #13587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
integration: homekit
small-pr
2 tasks
balloob
reviewed
Apr 1, 2018
| @@ -36,6 +36,7 @@ def validate_entity_config(values): | |||
| def show_setup_message(bridge, hass): | |||
| """Display persistent notification with setup information.""" | |||
| pin = bridge.pincode.decode() | |||
| _LOGGER.info('Pincode: %s', pin) | |||
There was a problem hiding this comment.
Info is the default logging message. Do we really always want to log it?
There was a problem hiding this comment.
Since it is in show_setup_message, it is only being logged if HomeKit isn't paired. If I set this to debug, it might become confusing since that would generate quite a lot of other messages.
balloob
pushed a commit
that referenced
this pull request
Apr 1, 2018
* Add pincode log statement * Moved msg to show_setup_msg
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added fallback solution to find the pincode for HomeKit.
Related issue: fixes #13566
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5067
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests pass