Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pincode fallback #13587

Merged
merged 2 commits into from
Apr 1, 2018
Merged

Add pincode fallback #13587

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bbd18d
Add pincode log statement
cdce8p Mar 31, 2018
5500b2b
Moved msg to show_setup_msg
cdce8p Mar 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions homeassistant/components/homekit/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ def validate_entity_config(values):
def show_setup_message(bridge, hass):
"""Display persistent notification with setup information."""
pin = bridge.pincode.decode()
_LOGGER.info('Pincode: %s', pin)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Info is the default logging message. Do we really always want to log it?

Copy link
Member Author

@cdce8p cdce8p Apr 1, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is in show_setup_message, it is only being logged if HomeKit isn't paired. If I set this to debug, it might become confusing since that would generate quite a lot of other messages.

message = 'To setup Home Assistant in the Home App, enter the ' \
'following code:\n### {}'.format(pin)
hass.components.persistent_notification.create(
Expand Down