Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 0/1 for raspberry pi cover GPIO writes rather than true/false #13610

Merged
merged 2 commits into from
Apr 1, 2018
Merged

Use 0/1 for raspberry pi cover GPIO writes rather than true/false #13610

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57f7e43
Use 0/1 for GPIO writes rather than true/false
fezfox Apr 1, 2018
6c04f5a
Update rpi_gpio.py
fezfox Apr 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions homeassistant/components/cover/rpi_gpio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def __init__(self, name, relay_pin, state_pin, state_pull_mode,
self._invert_relay = invert_relay
rpi_gpio.setup_output(self._relay_pin)
rpi_gpio.setup_input(self._state_pin, self._state_pull_mode)
rpi_gpio.write_output(self._relay_pin, not self._invert_relay)
rpi_gpio.write_output(self._relay_pin, 0 if self._invert_relay else 1)

@property
def name(self):
Expand All @@ -105,9 +105,9 @@ def is_closed(self):

def _trigger(self):
"""Trigger the cover."""
rpi_gpio.write_output(self._relay_pin, self._invert_relay)
rpi_gpio.write_output(self._relay_pin, 1 if self._invert_relay else 0)
sleep(self._relay_time)
rpi_gpio.write_output(self._relay_pin, not self._invert_relay)
rpi_gpio.write_output(self._relay_pin, 0 if self._invert_relay else 1)

def close_cover(self, **kwargs):
"""Close the cover."""
Expand Down