Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique_id to MQTT Light #16303

Merged
merged 2 commits into from
Sep 1, 2018
Merged

Add unique_id to MQTT Light #16303

merged 2 commits into from
Sep 1, 2018

Conversation

bieniu
Copy link
Member

@bieniu bieniu commented Aug 30, 2018

Description:

Add unique_id to MQTT Light

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6121

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Aug 30, 2018
def unique_id(self):
"""Return a unique ID."""
return self._unique_id

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line contains whitespace

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit e75a169 into home-assistant:dev Sep 1, 2018
@ghost ghost removed the in progress label Sep 1, 2018
@balloob balloob mentioned this pull request Sep 17, 2018
nikolaykasyanov added a commit to nikolaykasyanov/home-assistant that referenced this pull request Sep 19, 2018
Applies changes from home-assistant#16303 to mqtt_json component.
Fixes home-assistant#16600.
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
@bieniu bieniu deleted the patch-1 branch March 26, 2019 09:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants