Add unique_id to mqtt_json light #16721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nikolaykasyanov, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
homeassistant
added
cla-needed
platform: light.mqtt_json
small-pr
ghost
added
in progress
and removed
platform: light.mqtt_json
small-pr
houndci-bot
reviewed
Sep 19, 2018
| @@ -120,14 +123,15 @@ | |||
| class MqttJson(MqttAvailability, Light): | |||
| """Representation of a MQTT JSON light.""" | |||
|
|
|||
| def __init__(self, name, effect_list, topic, qos, retain, optimistic, | |||
| def __init__(self, name, unique_id, effect_list, topic, qos, retain, optimistic, | |||
There was a problem hiding this comment.
line too long (84 > 79 characters)
2 tasks
Applies changes from home-assistant#16303 to mqtt_json component. Fixes home-assistant#16600.
nikolaykasyanov
force-pushed
the
mqtt-json-light-unique-id
branch
from
994f645
to
a271342
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Applies changes from #16303 to mqtt_json component.
Related issue (if applicable): fixes #16600
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6319
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: