Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cover tests #16832

Merged
merged 7 commits into from
Sep 25, 2018
Merged

Update cover tests #16832

merged 7 commits into from
Sep 25, 2018

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Sep 24, 2018

Description:

First preparations for home-assistant/architecture#58
I've removed all test references to the cover services helpers. In addition the following test files are now async:

  • cover/test_command_line.py
  • cover/test_demo.py
  • cover/test_group.py

Since I didn't jet remove the service helpers, this PR does not contain any breaking changes.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
    If the code does not interact with devices:

@ghost ghost assigned cdce8p Sep 24, 2018
@ghost ghost added the in progress label Sep 24, 2018
@balloob
Copy link
Member

balloob commented Sep 25, 2018

If we can, we should just move the Cover service call helpers to tests/components/cover/__init__.py . That way we don't have to change the tests and can implement this faster.

@cdce8p
Copy link
Member Author

cdce8p commented Sep 25, 2018

@balloob I could remove the Cover service call helpers if you want to. This PR removes all references to them. I just didn't do it since it might break some custom components.

@balloob
Copy link
Member

balloob commented Sep 25, 2018

Let's remove them.

@cdce8p cdce8p merged commit 7eaf864 into home-assistant:dev Sep 25, 2018
@ghost ghost removed the in progress label Sep 25, 2018
@cdce8p cdce8p deleted the remove-service-helper-covers branch September 25, 2018 20:32
@balloob balloob mentioned this pull request Oct 12, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants