-
-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cover tests #16832
Merged
cdce8p
merged 7 commits into
home-assistant:dev
from
cdce8p:remove-service-helper-covers
Sep 25, 2018
Merged
Update cover tests #16832
cdce8p
merged 7 commits into
home-assistant:dev
from
cdce8p:remove-service-helper-covers
Sep 25, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
approved these changes
Sep 25, 2018
If we can, we should just move the Cover service call helpers to |
@balloob I could remove the Cover service call helpers if you want to. This PR removes all references to them. I just didn't do it since it might break some custom components. |
Let's remove them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
First preparations for home-assistant/architecture#58
I've removed all test references to the cover services helpers. In addition the following test files are now async:
cover/test_command_line.py
cover/test_demo.py
cover/test_group.py
Since I didn't jet remove the service helpers, this PR does not contain any breaking changes.
Checklist:
tox
. Your PR cannot be merged unless tests passIf the code does not interact with devices: