Remove service helper (2) #16863
Merged
Remove service helper (2) #16863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
balloob
reviewed
Sep 25, 2018
tests/components/climate/common.py
Outdated
| @@ -0,0 +1,111 @@ | |||
| """Collection of helper methods.""" | |||
There was a problem hiding this comment.
Can we update the description of each of these files to say that these are legacy helpers and should not be mimicked in new components.
There was a problem hiding this comment.
👍 I've updated the descriptions.
2 tasks
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Additional work for: home-assistant/architecture#58
Instead of rewriting every test (what I did with #16832), I only moved the service helpers to
test/[component]/common.pyand rewrote the references, as suggested.Checklist:
tox. Your PR cannot be merged unless tests pass