Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use keyset #17984

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Don't use keyset #17984

merged 1 commit into from
Oct 29, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Oct 29, 2018

Description:

Removes fetching the keyset. It's only used to verify that we read sub-exp correctly, which is being verified in the cloud anyway.

Related issue (if applicable): fixes #14089, fixes #15221

Example entry for configuration.yaml (if applicable):

cloud:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.81.2 milestone Oct 29, 2018
@balloob balloob requested a review from a team as a code owner October 29, 2018 20:15
@ghost ghost assigned balloob Oct 29, 2018
@ghost ghost added the in progress label Oct 29, 2018
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/linters/.local/bin/flake8", line 7, in 
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

@balloob balloob merged commit 2f71f89 into dev Oct 29, 2018
@ghost ghost removed the in progress label Oct 29, 2018
balloob added a commit that referenced this pull request Oct 29, 2018
@balloob balloob mentioned this pull request Oct 29, 2018
@pvizeli pvizeli deleted the remove-keyset branch October 29, 2018 21:18
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to reach the Home Assistant cloud. Repeated Error fetching Cognito keyset
5 participants