Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change log level from error to warning of media_player.plex #19035

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Change log level from error to warning of media_player.plex #19035

merged 1 commit into from
Dec 5, 2018

Conversation

doudz
Copy link
Contributor

@doudz doudz commented Dec 5, 2018 •
edited

Description:

Workaround, to avoid filling log with error when Plex server is down

Related issue (if applicable): fixes #16653

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Dec 5, 2018
@doudz doudz changed the title Change error to warning media_player.plex : Change log level from error to warning Dec 5, 2018
@fabaff fabaff changed the title media_player.plex : Change log level from error to warning Change log level from error to warning of media_player.plex Dec 5, 2018
fabaff
fabaff approved these changes Dec 5, 2018
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐦

@doudz
Copy link
Contributor Author

doudz commented Dec 5, 2018

What's the problem with Travis ???

@fabaff fabaff merged commit 3627de3 into home-assistant:dev Dec 5, 2018
@ghost ghost removed the in progress label Dec 5, 2018
@balloob balloob mentioned this pull request Dec 12, 2018
Merged
@ThomasPrior ThomasPrior mentioned this pull request Dec 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

Assignees
No one assigned
Labels
cla-signed integration: plex small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plex activity sensor is to annoying when Plex server is down
3 participants
@doudz @fabaff @homeassistant