New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for color_temp_command_template in MQTT light component #19675
Conversation
Hi @dchesterton, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
@@ -207,6 +209,7 @@ def _setup_from_config(self, config): | |||
self._templates = { | |||
CONF_BRIGHTNESS: config.get(CONF_BRIGHTNESS_VALUE_TEMPLATE), | |||
CONF_COLOR_TEMP: config.get(CONF_COLOR_TEMP_VALUE_TEMPLATE), | |||
CONF_COLOR_TEMP_COMMAND_TEMPLATE: config.get(CONF_COLOR_TEMP_COMMAND_TEMPLATE), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (91 > 79 characters)
Please add an abbreviation for the new configuration variable in mqtt/discovery.py |
Thanks, I've added the abbreviation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
…ome-assistant#19675) * Add support for color_temp_command_template in MQTT light component
…ome-assistant#19675) * Add support for color_temp_command_template in MQTT light component
Description:
Add support for changing the MQTT color_temp command with the
color_temp_command_template
config option, in the same way as the existingrgb_command_template
config option. This adds support for devices which expect the color_temp to be in Kelvin, such as SmartThings and Hubitat.Related issue (if applicable): fixes #19673 (among others)
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8000
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices: