Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use voluptuous to perform validation for the geofency webhook #20067

Merged
merged 3 commits into from
Jan 15, 2019
Merged

Use voluptuous to perform validation for the geofency webhook #20067

merged 3 commits into from
Jan 15, 2019

Conversation

rohankapoorcom
Copy link
Member

Description:

Replaced a bunch of custom validation code by using voluptuous instead.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Jan 13, 2019
@pvizeli pvizeli merged commit 80bc42a into home-assistant:dev Jan 15, 2019
@ghost ghost removed the in progress label Jan 15, 2019
@rohankapoorcom rohankapoorcom deleted the cleanup-geofency branch January 15, 2019 15:31
@balloob balloob mentioned this pull request Jan 23, 2019
Merged
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019
@rohankapoorcom @alandtse
Use voluptuous to perform validation for the geofency webhook (home-a…
7b95197 
…ssistant#20067)

* Use voluptuous to perform validation for the geofency webhook

* Add missing attribute to schema

* Lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvizeli pvizeli pvizeli approved these changes

Assignees
No one assigned
Labels
cla-signed integration: geofency small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rohankapoorcom @pvizeli @homeassistant