New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added component camect, which streams camera video using WebRTC #22446
Conversation
Thanks for willing to integrate your product into Home Assistant. However, your integration doesn't implement the most important HA camera's method |
@awarecan Thanks for the quick response. We don't do the usual image camera way. |
This is not how Home Assistant works. We don't create a front end card only for one device. I am not sure if you have look at our new I would not accept a WebRTC feature which only support one specific vendor's device. Of course, that is only my personal opinion, you can still seek other members support. We had some discussion about how far we want HA goes towards a surveillance system (maybe it is your product's position), most of us feel that HA is not and should not become a surveillance system. Base on this, I would recommend you rethink how you want to interact with HA, I suggest you can develop a hass.io add-ons, to loosely integrate with HA. I strongly suggest you checkout this MotionEye Addons If you still feel that integrate into HA is important, then I would suggest you look at ZoneMinder as a reference. |
@awarecan Thanks for all these suggestions. I think we still want an integration instead of an addon.
|
It sounds good. |
Custom cards living outside of HA is fine. Probably even the best approach as then people can mix and match with other Lovelace things. You can also consider using either |
Also, consider adding a description to your PR 🤷♂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of weird things in this PR. From routing font + JS files, forwarding all events to our event bus and not following platform requiremenets.
We will not further review any part of this PR until you add a description to your PR about who you are, what you are planning to do, and how integrating with us fits in.
I agree with everyone here. Your On another note, I am looking at expanding the |
@balloob I fixed the problems you pointed out. Added a description to the PR. Sorry I missed it at the beginning. Let me know if more details are wanted. Thanks. |
@hunterjm Thanks for the suggestions. To make sure I understand it correctly, do you plan to support WebRTC in stream component so it could feed RTSP/HLS video to Alexa using WebRTC? Or the other direction, consume WebRTC and convert that to HLS so frontend could stream it? |
…is only supported by py3.6 and later.
After talked with our users, we think we'll go with a custom component instead. This way, we'll be able to provide more functionality like alerts to users. I'll close this thread for now. Thanks for all your help! |
Description:
Integrate with Camect, an affordable smart NVR, which cares about your privacy. See https://camect.com/ for more information.
This PR adds a new platform to the camera component so users could view cameras supported by Camect. In the future, we'll provide instructions to add a custom card so users will be able to view live video / footage / alerts using WebRTC.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: