New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary sensors for netgear_lte #22902
Binary sensors for netgear_lte #22902
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #22902 +/- ##
=======================================
Coverage 93.83% 93.83%
=======================================
Files 448 448
Lines 36574 36574
=======================================
Hits 34321 34321
Misses 2253 2253
Continue to review full report at Codecov.
|
BINARY_SENSOR_MOBILE_CONNECTED = 'mobile_connected' | ||
|
||
BINARY_SENSOR_CLASSES = { | ||
'roaming': None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am in doubt about the proper device class to use here. The UI currently shows a checkmark when roaming and that seems odd. However, "roaming" is the terminology normally used so I see no way of reversing the naming without causing confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a better solution here.
@MartinHjelmare I don't normally ask for reviews but it would be good to get this in before the beta and it is mostly small changes to code that you already reviewed, so if you have the time ... |
Thank you. I added the documentation update now. |
I've commented on the docs PR. Go ahead and merge when everything is ready. 👍 |
Description:
Follow-up to #22558 where @rohankapoorcom pointed out that some of the sensors should have been binary sensors. Since #22558 is not released yet, this is not a breaking change.
Most of the changes here are due to moving shared methods to a base class in the component. The rest is a binary_sensor implementation, mostly copy/pasting the existing sensor implementation. I did not split into several PRs mostly because the clock is ticking on the next beta.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#9178
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
.If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
requirements
in the manifest (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.