Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add incomfort climate and bump client #23830

Merged
merged 4 commits into from May 12, 2019
Merged

Add incomfort climate and bump client #23830

merged 4 commits into from May 12, 2019

Conversation

zxdavb
Copy link
Contributor

@zxdavb zxdavb commented May 12, 2019

Breaking Change:

None known.

Description:

Adds climate entities to the intouch platform.

Related issue (if applicable): bumps client to address a KeyError that becomes only apparent with climate entities.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Unchanged.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@zxdavb zxdavb changed the title Add climate to incomfort, bump client Add incomfort climate and bump client May 12, 2019
@zxdavb
Copy link
Contributor Author

zxdavb commented May 12, 2019

@MartinHjelmare This should be OK to go.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@MartinHjelmare MartinHjelmare merged commit 2a9fd9a into home-assistant:dev May 12, 2019
@zxdavb
Copy link
Contributor Author

zxdavb commented May 12, 2019

What! No changes? Woot!

@zxdavb zxdavb deleted the add_climate_to_incomfort branch May 12, 2019 14:43
@balloob balloob mentioned this pull request Jun 4, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
* Initial commit

* bump client for bugfix

* bump client for bugfix 2

* de-lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants