Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add incomfort climate, sensor and binary_sensor #9654

Merged
merged 5 commits into from Jun 19, 2019
Merged

Add incomfort climate, sensor and binary_sensor #9654

merged 5 commits into from Jun 19, 2019

Conversation

zxdavb
Copy link
Contributor

@zxdavb zxdavb commented Jun 19, 2019

Description:
Adds Room thermostats & Sensors to the incomfort integration.

Pull request in home-assistant (if applicable):
home-assistant/core#23812
home-assistant/core#23830

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next home-assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@klaasnicolaas klaasnicolaas added has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch ready-for-review This PR needs to be reviewed labels Jun 19, 2019
@zxdavb zxdavb changed the title add incomfort climate, sensors Add incomfort climate, sensors Jun 19, 2019
@zxdavb zxdavb changed the title Add incomfort climate, sensors Add incomfort climate, sensor and binary_sensor Jun 19, 2019
@frenck frenck added the parent-merged The parent PR has been merged already label Jun 19, 2019
@frenck frenck removed parent-merged The parent PR has been merged already ready-for-review This PR needs to be reviewed labels Jun 19, 2019
@frenck
Copy link
Member

frenck commented Jun 19, 2019

Thanks, @zxdavb! That was a smooth sail ⛵️ 👍

@frenck frenck merged commit 1b954e9 into home-assistant:next Jun 19, 2019
@zxdavb
Copy link
Contributor Author

zxdavb commented Jun 19, 2019

Thanks, not often I get something past you guys with no corrections.

@zxdavb zxdavb deleted the add_incomfort_sensors branch June 19, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants