Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ZHA battery level when value is reported via signal #24371

Merged
merged 2 commits into from
Jun 7, 2019

Conversation

dmulcahey
Copy link
Contributor

Description:

This PR fixes battery level reports for ZHA devices

Related issue (if applicable): fixes #24342

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

@dmulcahey dmulcahey requested a review from Adminiuga June 7, 2019 12:16
@homeassistant homeassistant added cla-signed small-pr PRs with less than 30 lines. labels Jun 7, 2019
@ghost ghost assigned Adminiuga and dmulcahey Jun 7, 2019
@ghost
Copy link

ghost commented Jun 7, 2019

Hey there @Adminiuga, mind taking a look at this pull request as its been labeled with a integration (zha) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@dmulcahey dmulcahey changed the title fix battery signal Fix ZHA battery level when value is reported via signal Jun 7, 2019
Copy link
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge when build passes.

Copy link
Member

@andrewsayre andrewsayre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Adminiuga Adminiuga merged commit a79224a into home-assistant:dev Jun 7, 2019
@balloob balloob mentioned this pull request Jun 26, 2019
@dmulcahey dmulcahey deleted the dm/fix-battery branch July 18, 2019 10:54
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed integration: zha small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZHA battery level is sometimes wrong
4 participants