Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ZLO device types to support newer Zigbee devices in ZHA #24429

Merged
merged 4 commits into from
Jun 11, 2019

Conversation

jurriaan
Copy link
Contributor

@jurriaan jurriaan commented Jun 9, 2019

Description:

Support the device types that are added in zigpy/zigpy#176
so newer Zigbee (3.0) devices can be supported.

Tested with my innr RB 285 C bulb.

This PR is waiting for an official zigpy release (cc @Adminiuga)

See zigpy/zigpy#176

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Can be verified after release of zigpy
  • There is no commented out code in this PR.
  • I have followed the development checklist

@homeassistant

This comment has been minimized.

@ghost ghost assigned Adminiuga and dmulcahey Jun 9, 2019
@ghost
Copy link

ghost commented Jun 9, 2019

Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as its been labeled with a integration (zha) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

Copy link
Contributor

@dmulcahey dmulcahey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the mappings to Binary Sensor

@dmulcahey
Copy link
Contributor

can merge once builds pass

@Adminiuga
Copy link
Contributor

Um, we have to push new zigpy version to PyPi for the build to pass.

@jurriaan
Copy link
Contributor Author

@Adminiuga correct, mentioned that in this PR description. Is it possible for you to push a new version?

@Adminiuga
Copy link
Contributor

@jurriaan just pushed new version to PyPi. Update the manifest.json and run script/gen_requirements_all.py

@dmulcahey is it ok to bump version for zigpy in this PR you would you like a new one?

@dmulcahey
Copy link
Contributor

Same is fine by me...

@Adminiuga
Copy link
Contributor

aprs device tracker breaks this build...

Copy link
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for merging.

@Adminiuga
Copy link
Contributor

@jurriaan do you want to try rebasing it to prior 8fcfcc4#diff-34298aba7fdfcffa995d0a1fd0b2a068 commit? To exclude homeassistant.components.aprs, as it seems device tracker is breaking the builds.

Support the device types that are added in zigpy/zigpy#176
so newer Zigbee devices can be supported.
Since they are target devices I've added them as switch and lights,
which matches the Zigbee documentation.
To be able to use the new DeviceTypes
@jurriaan
Copy link
Contributor Author

@Adminiuga Rebased and green

@Adminiuga Adminiuga merged commit b87c541 into home-assistant:dev Jun 11, 2019
@balloob balloob mentioned this pull request Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed integration: zha small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants