-
-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ZLO device types to support newer Zigbee devices in ZHA #24429
Support ZLO device types to support newer Zigbee devices in ZHA #24429
Conversation
This comment has been minimized.
This comment has been minimized.
Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the mappings to Binary Sensor
can merge once builds pass |
Um, we have to push new zigpy version to PyPi for the build to pass. |
@Adminiuga correct, mentioned that in this PR description. Is it possible for you to push a new version? |
@jurriaan just pushed new version to PyPi. Update the manifest.json and run @dmulcahey is it ok to bump version for zigpy in this PR you would you like a new one? |
ad91817
to
73c8cf4
Compare
Same is fine by me... |
73c8cf4
to
4aba7c0
Compare
aprs device tracker breaks this build... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for merging.
@jurriaan do you want to try rebasing it to prior 8fcfcc4#diff-34298aba7fdfcffa995d0a1fd0b2a068 commit? To exclude |
Support the device types that are added in zigpy/zigpy#176 so newer Zigbee devices can be supported.
Since they are target devices I've added them as switch and lights, which matches the Zigbee documentation.
To be able to use the new DeviceTypes
4aba7c0
to
a9fe722
Compare
@Adminiuga Rebased and green |
Description:
Support the device types that are added in zigpy/zigpy#176
so newer Zigbee (3.0) devices can be supported.
Tested with my innr RB 285 C bulb.
This PR is waiting for an official zigpy release (cc @Adminiuga)
See zigpy/zigpy#176
Checklist:
tox
. Can be verified after release of zigpy