Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for innr RB 285 C #91

Closed

Conversation

jurriaan
Copy link

@jurriaan jurriaan commented Jun 7, 2019

So the color is adjustable and the light is dimmable.

And add innr devices to the README

And add innr devices to the README
Copy link
Collaborator

@dmulcahey dmulcahey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the quirk do that ZHA doesn't handle on its own? I think I see it... device type reassignment?

'manufacturer': 'innr',
'model': 'RB 285 C',
'profile_id': zha.PROFILE_ID,
'device_type': 269,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a constant for this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, should've read the contributer documentation about this, just copied the existing innr quirk.

I found out that this device type is an 'Extended Colour Light', so probably we need to add support to home assistant/zigpy for these types so we don't need quirks. What do you think?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# output_clusters=[33]>
242: {
'profile_id': 41440,
'device_type': 97,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

# input_clusters=[]
# output_clusters=[33]>
242: {
'profile_id': 41440,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

],
},
242: {
'profile_id': 41440,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

},
242: {
'profile_id': 41440,
'device_type': 97,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@jurriaan
Copy link
Author

jurriaan commented Jun 9, 2019

Thanks for the pointers on how to fix this @dmulcahey!

zigpy/zigpy#176 has been merged, and I just opened home-assistant/core#24429.

When both are merged I think the quirks for the innr RS 228 T can be removed from this repository, as that bulb also does device type reassignment, but then for the newly added zha.DeviceType.COLOR_TEMPERATURE_LIGHT.

@dmulcahey
Copy link
Collaborator

sounds good. Thanks for the contributions!!!

@jurriaan
Copy link
Author

jurriaan commented Jun 9, 2019

:) Will close this PR since this doesn't make sense anymore.

@jurriaan jurriaan closed this Jun 9, 2019
@jurriaan jurriaan deleted the add-support-for-innr-rb-285-c branch June 9, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants