Deprecates fedex integration (ADR-0004) #25745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
integration: fedex
small-pr
2 tasks
|
Can you update the breaking changes section to include instructions on how the user can continue to use this integration as a custom component? |
andrewsayre
reviewed
Aug 7, 2019
| "The fedex integration is deprecated and will be removed " | ||
| "in Home Assistant 0.100.0. For more information see ADR-0004:" | ||
| "https://github.com/home-assistant/architecture/blob/master/adr/0004-webscraping.md" | ||
| ) |
There was a problem hiding this comment.
Suggest the string also mention they could copy the integration to a custom component if they desire to retain the functionality.
There was a problem hiding this comment.
I think that is a good idea, but we should do that for all in blogpost.
pvizeli
approved these changes
Aug 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
The FedEx integration has been deprecated and is pending for removal in Home Assistant 0.100.0.
Description:
This PR deprecates the FedEx integration since it relies on web scraping to function.
As per ADR-0004 this is no longer allowed. The integration should now be deprecated for 2 releases before permanent removal.
Related issue (if applicable): #24332 #13131
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10070
Example entry for
configuration.yaml(if applicable): n/aChecklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: