New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tahoma reversed closed status for non horizontal awnings #26840
Conversation
This feels like a never-ending PR/discussion. The PR you mentioned as the source of the issue, has actually been reverted, so your callout makes no sense.
Related discussions and issues:
I feel like we should stop the juggle and add support for a |
Thanks @frenck for your reply. #24879 has not resolved this issue. In 0.99.2 the problem still persists because this PR has not fixed the reversed closed state introduced by #23257, ie:
I think that the |
Hello, any news concerning this fix? All Tahoma users should be impacting by the change in #23257, which reverses the open/closed states. |
I don't understand how to solve it. I'm on HA 0.94.4, if update i get wrong open/close status. |
@pax2011, fix the reversed statuses is the purpose of this PR (pull request). To fix this problem, you can wait until this correction is included in a future version of HA. Another solution is to use my modified code by downloading my version of the tahoma component, and use it has a remplacement of the one embedded in home assistant. You can follow these instructions to install a custom component in your config directory. My modified Tahoma component is available here. |
I did it! Thanks man. Updated HA, used your code and now is working. |
@pax2011 🎉 |
Hello, I have updated to 0.99.3 but I still have the issue on the state of my covers, closed when open open when closed. |
This will be released on Wednesday. |
Home Assistant release with the issue:
0.99.2
Operating environment (Hass.io/Docker/Windows/etc.):
Hass.io
Description:
Related issue: fixes #25240
Also fixes the closed status when the position is changed when the position is
<= 5
or when the position is>= 95
.The problem appeared in #23257 where the right closed status has been modified for non horizontal awnings (file
homeassistant/components/tahoma/cover.py
, removed line 117).Example entry for
configuration.yaml