Add Luxtronik integration for multiple heat pump models #27230

Bouni · 2019-10-05T18:41:42Z

Description:

Add support for heat pump units controlled by a Luxtronik controller.

Manufacturers that use Luxtronik heat pump controllers are:

Alpha Innotec
Siemens Novelan
Roth
Elco
Buderus
Nibe
Wolf Heiztechnik

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10621

Example entry for `configuration.yaml` (if applicable):

luxtronik:
  host: 192.168.178.10
  port: 8889

Checklist:

[ x ] The code change is tested and works locally.
[ x ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[ x ] There is no commented out code in this PR.
[ x ] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[ x ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ x ] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[ x ] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ x ] Untested files have been added to .coveragerc.

If the code does not interact with devices:

Tests have been added to verify that the new code works.

Bouni · 2019-10-14T19:01:51Z

I maybe change the naming scheme depending on what the users of my custom component vote for.
Furthermore I might add a climate component as @renevdzee did in his fork of my custom component

Bouni · 2019-11-15T14:17:45Z

I think I'm done. I have this component running with my heatpump for quite a while and havn't encountered any problems so far.

springstan

Just some small stuff to start the reviewing process :)

homeassistant/components/luxtronik/services.yaml

springstan

Just some more small stuff to get you started :)

homeassistant/components/luxtronik/manifest.json

homeassistant/components/luxtronik/sensor.py

homeassistant/components/luxtronik/__init__.py

homeassistant/components/luxtronik/binary_sensor.py

homeassistant/components/luxtronik/sensor.py

homeassistant/components/luxtronik/binary_sensor.py

Bouni · 2019-12-10T13:18:56Z

I'll take a look at all your points soon!

homeassistant/components/luxtronik/__init__.py

homeassistant/components/luxtronik/sensor.py

remyderuysscher · 2020-01-23T06:37:06Z

@springstan @Bouni What's the hold up? I would to see this component merged asap. If there is anything I can do to help?

Bouni · 2020-01-23T07:46:19Z

@remyderuysscher I'm very busy at the moment and whenever @springstan asked me to change certain things, it took several days until I was able to react. Thats probably the main reason why this takes longer than usual.

Bouni · 2020-01-27T11:25:14Z

@springstan Is there anything else you wan't me to change / improve?

remyderuysscher · 2020-01-27T18:03:10Z

@remyderuysscher I'm very busy at the moment and whenever @springstan asked me to change certain things, it took several days until I was able to react. Thats probably the main reason why this takes longer than usual.

I understand, I'm here to help if needed!

homeassistant/components/luxtronik/__init__.py

homeassistant/components/luxtronik/binary_sensor.py

homeassistant/components/luxtronik/sensor.py

homeassistant/components/luxtronik/__init__.py

balloob · 2020-02-09T01:16:22Z

homeassistant/components/luxtronik/__init__.py

+    port = conf[CONF_PORT]
+    safe = conf[CONF_SAFE]
+
+    luxtronik = LuxtronikDevice(host, port, safe)


Can you verify here that the connection works ?

I could check if the used lib got data from the heatpump?
Is that an option?

balloob · 2020-02-09T01:16:46Z

homeassistant/components/luxtronik/__init__.py

+        self._host = host
+        self._port = port
+        self._luxtronik = Lux(host, port, safe)
+        self.update()


No side effects in the constructor, pass True as second arg to add_entities instead.

Can you give an other integration as an example?

balloob · 2020-02-09T01:17:58Z

homeassistant/components/luxtronik/__init__.py

+
+        self._host = host
+        self._port = port
+        self._luxtronik = Lux(host, port, safe)


Is this data shared between multiple devices ?

You mean in case somebody uses this integration fro two heatpumps to connect to?

homeassistant/components/luxtronik/sensor.py

bdraco · 2020-03-23T18:03:53Z

Hi @Bouni , it looks like this one got pretty close. Are you still working on this. PR?

Bouni · 2020-03-23T18:26:17Z

@bdraco Kind of, I wait for one of the maintainers to look at the latest changes I made, on the other hand, there are some open issues I don't know how to fix 😞
For example the requested "Data Update Coordinator" thing.
I fear that I'm not a experienced enough programmer to get this to a point that the maintainers will merge this.

frenck · 2020-03-23T19:45:54Z

Ok, @Bouni Let's resolve all comments you've handled. That way you get a better overview of what is open and what is done.
There are some comments open that definitely still can be worked on...

Bouni · 2020-03-24T06:05:38Z

@frenck Highly appreciate your help!
Maybe a stupid question, but do I have to resolve them and if so by clicking the Resolve conflicts button? I'm not very experianced with the process here on GitHub.

frenck · 2020-03-24T12:08:20Z

Yes, you can close a review comment by clicking resolve (only do that when it is actually resolved ;) ) After that, you will be left with things that need either discussion or still need adjustment. Which makes it easier to overview for you and everybody else.

Schack17 · 2020-04-16T20:14:13Z

@Bouni
It would be great if the module were soon available in home assistant. Can anyone help?

Bouni · 2020-04-17T07:08:34Z

@Schack17 I will continue on this next week hopefully!

VincentVegaOne · 2020-04-29T11:24:29Z

that integration looks great and is exactly what i need! Excited to test it when its ready.

Bouni · 2020-04-30T07:52:49Z

I think I'll release a HACS version of this today so that people can start using it.

After thats done, I can focus on fixing all the remaining issues with this PR.
I think that I need to create a config flo for this a swell as it it required no I guess!?
@frenck Is that the case now for all new integrations?

Bouni · 2020-04-30T09:42:28Z

OK, the HACS repo is done, until it is integrated with HACS officially, you can add it as a custom repo in HACS using the Github URL: https://github.com/Bouni/luxtronik

remyderuysscher · 2020-05-01T19:43:21Z

@Bouni the code crashes on parsing a 10.0.0.0/8 IP address.

File "/usr/local/lib/python3.7/ipaddress.py", line 1312, in init
self._check_int_address(address)
File "/usr/local/lib/python3.7/ipaddress.py", line 424, in _check_int_address
self._version))
ipaddress.AddressValueError: 4466016928 (>= 2**32) is not permitted as an IPv4 address

Bouni · 2020-05-04T11:01:04Z

@remyderuysscher Please do not report issues with the HACS version here!
The repo you're looking for is https://github.com/Bouni/luxtronik

stale · 2020-06-03T11:07:25Z

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

frenck · 2020-06-03T20:41:40Z

This PR is running stale and has requested changes. Closing this PR for now. Feel free to re-open when ready to work on it again.

Thanks 👍

homeassistant added the cla-signed label Oct 5, 2019

probot-home-assistant bot added new-integration integration: luxtronik labels Oct 5, 2019

Bouni mentioned this pull request Oct 5, 2019

Documentation for Luxtronik integration home-assistant/home-assistant.io#10621

Closed

balloob added the Hacktoberfest label Oct 6, 2019

Bouni changed the title ~~Add Luxtronik integration for multiple heat pump models~~ [WIP] Add Luxtronik integration for multiple heat pump models Oct 14, 2019

Bouni changed the title ~~[WIP] Add Luxtronik integration for multiple heat pump models~~ Add Luxtronik integration for multiple heat pump models Nov 15, 2019

springstan requested changes Dec 3, 2019

View reviewed changes

homeassistant/components/luxtronik/services.yaml Outdated Show resolved Hide resolved

springstan requested changes Dec 3, 2019

View reviewed changes

Bouni mentioned this pull request Dec 10, 2019

SET Bouni/node-red-contrib-luxtronik2-ws#7

Closed

springstan reviewed Dec 16, 2019

View reviewed changes

homeassistant/components/luxtronik/__init__.py Outdated Show resolved Hide resolved

springstan reviewed Dec 16, 2019

View reviewed changes

homeassistant/components/luxtronik/sensor.py Outdated Show resolved Hide resolved

springstan reviewed Dec 16, 2019

View reviewed changes

homeassistant/components/luxtronik/sensor.py Outdated Show resolved Hide resolved

springstan reviewed Jan 28, 2020

View reviewed changes

balloob reviewed Feb 9, 2020

View reviewed changes

homeassistant/components/luxtronik/__init__.py Outdated Show resolved Hide resolved

balloob reviewed Feb 9, 2020

View reviewed changes

homeassistant/components/luxtronik/sensor.py Outdated Show resolved Hide resolved

Bouni added 11 commits March 3, 2020 16:25

removed default value

d4b9137

changed several minor things in binary_sensor

9ad8d97

moved ICONS, DEVICE_CLASSES and UNITS to const.py

5b4c347

removed uneccessary default values

84b0ae1

fixed usage of string instead of constant

7c4665d

fixed tests

4e65fd3

changed data key to use DOMAIN

cf641ed

changed default device class to None

e5800eb

minor change to config checks

ceefdf2

removed custom logic for on/off icons

006571a

cleaned up consts

a67dcd7

stale bot added the stale label Jun 3, 2020

frenck closed this Jun 3, 2020

probot-home-assistant bot added invalid and removed Hacktoberfest labels Jun 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Luxtronik integration for multiple heat pump models #27230

Add Luxtronik integration for multiple heat pump models #27230

Bouni commented Oct 5, 2019

Bouni commented Oct 14, 2019

Bouni commented Nov 15, 2019

springstan left a comment

springstan left a comment •

edited

Loading

Bouni commented Dec 10, 2019

remyderuysscher commented Jan 23, 2020

Bouni commented Jan 23, 2020

Bouni commented Jan 27, 2020

remyderuysscher commented Jan 27, 2020

balloob Feb 9, 2020

Bouni Mar 3, 2020

balloob Feb 9, 2020 •

edited

Loading

Bouni Mar 3, 2020

balloob Feb 9, 2020

Bouni Mar 3, 2020

bdraco commented Mar 23, 2020

Bouni commented Mar 23, 2020

frenck commented Mar 23, 2020

Bouni commented Mar 24, 2020

frenck commented Mar 24, 2020

Schack17 commented Apr 16, 2020

Bouni commented Apr 17, 2020

VincentVegaOne commented Apr 29, 2020

Bouni commented Apr 30, 2020

Bouni commented Apr 30, 2020

remyderuysscher commented May 1, 2020

Bouni commented May 4, 2020

stale bot commented Jun 3, 2020

frenck commented Jun 3, 2020

Add Luxtronik integration for multiple heat pump models #27230

Add Luxtronik integration for multiple heat pump models #27230

Conversation

Bouni commented Oct 5, 2019

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

Bouni commented Oct 14, 2019

Bouni commented Nov 15, 2019

springstan left a comment

Choose a reason for hiding this comment

springstan left a comment • edited Loading

Choose a reason for hiding this comment

Bouni commented Dec 10, 2019

remyderuysscher commented Jan 23, 2020

Bouni commented Jan 23, 2020

Bouni commented Jan 27, 2020

remyderuysscher commented Jan 27, 2020

balloob Feb 9, 2020

Choose a reason for hiding this comment

Bouni Mar 3, 2020

Choose a reason for hiding this comment

balloob Feb 9, 2020 • edited Loading

Choose a reason for hiding this comment

Bouni Mar 3, 2020

Choose a reason for hiding this comment

balloob Feb 9, 2020

Choose a reason for hiding this comment

Bouni Mar 3, 2020

Choose a reason for hiding this comment

bdraco commented Mar 23, 2020

Bouni commented Mar 23, 2020

frenck commented Mar 23, 2020

Bouni commented Mar 24, 2020

frenck commented Mar 24, 2020

Schack17 commented Apr 16, 2020

Bouni commented Apr 17, 2020

VincentVegaOne commented Apr 29, 2020

Bouni commented Apr 30, 2020

Bouni commented Apr 30, 2020

remyderuysscher commented May 1, 2020

Bouni commented May 4, 2020

stale bot commented Jun 3, 2020

frenck commented Jun 3, 2020

Example entry for `configuration.yaml` (if applicable):

springstan left a comment •

edited

Loading

balloob Feb 9, 2020 •

edited

Loading