Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new humidifier entity integration #28693

Merged
merged 68 commits into from
Jun 23, 2020
Merged

Conversation

Shulyaka
Copy link
Contributor

@Shulyaka Shulyaka commented Nov 11, 2019

Description:

As per discussion in home-assistant/architecture#288, this is the pull request to add an integration for humidifier and dehumidifier devices, which are the consumer devices whose main purpose is to add or remove moisture from the air.
Once this PR is reviewed and merged, I will also raise separate pull requests for generic_hygrostat platform and for the humidity devices support in demo, emulated_hue, prometheus, homekit. and google_assistant integrations. However if you prefer I can combine it all in one PR.

Related issue (if applicable): N/A
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11151
Pull request with documentation for developers.home-assistant.io: home-assistant/developers.home-assistant#356
Architecture issue: home-assistant/architecture#310

Example entry for configuration.yaml (if applicable):

humidifier:
  - platform: humidifier_platform_1
    name: Hygrostat Zone 1
    ...
  - platform: humidifier_platform_2
    name: Humidifier Bedroom
    ...

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (history) you are listed as a codeowner for? Thanks!

@Shulyaka Shulyaka marked this pull request as ready for review November 11, 2019 12:14
@Shulyaka Shulyaka requested a review from a team as a code owner November 11, 2019 12:14
@Shulyaka
Copy link
Contributor Author

Looking into #28690 I realized that I also need to add support for the fan. Will do probably today or tomorrow.

@fabaff fabaff changed the title humidity: new domain Add new humidity support Nov 11, 2019
@MartinHjelmare MartinHjelmare changed the title Add new humidity support Add new humidity entity integration Nov 11, 2019
@Shulyaka
Copy link
Contributor Author

Rebased in an attempt to fix CI checks...

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It requires a demo platform in addition.

@Shulyaka
Copy link
Contributor Author

@fabaff Done.

@Shulyaka Shulyaka requested review from fabaff and removed request for a team November 13, 2019 08:27
@Shulyaka
Copy link
Contributor Author

I don't know how I removed review request from @home-assistant/core and how to add "integration: demo" label to this issue

@Shulyaka Shulyaka changed the title Add new humidity entity integration Add new humidifier entity integration Nov 13, 2019
@Shulyaka
Copy link
Contributor Author

I haven't started on frontend part yet (was waiting for this PR to be merged first), but if you think it is almost ready to be merged, I will start now. If anyone has his own plans for the frontend, please let me know.

@Shulyaka Shulyaka mentioned this pull request Jun 13, 2020
20 tasks
@Shulyaka
Copy link
Contributor Author

The frontend part is ready from my perspective.

@Shulyaka Shulyaka mentioned this pull request Jun 14, 2020
20 tasks
@balloob
Copy link
Member

balloob commented Jun 23, 2020

🎉 🎉 🎉

Will do a frontend release tomorrow that includes humidifier support.

@dshanske
Copy link

Can't wait till winter...

@lock lock bot locked and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.