-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new humidifier entity integration #28693
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( |
3451008
to
a14672d
Compare
Looking into #28690 I realized that I also need to add support for the fan. Will do probably today or tomorrow. |
581c7a5
to
e88a01f
Compare
Rebased in an attempt to fix CI checks... |
e88a01f
to
9d45d4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It requires a demo
platform in addition.
@fabaff Done. |
I don't know how I removed review request from @home-assistant/core and how to add "integration: demo" label to this issue |
57dc93e
to
3ce2809
Compare
I haven't started on frontend part yet (was waiting for this PR to be merged first), but if you think it is almost ready to be merged, I will start now. If anyone has his own plans for the frontend, please let me know. |
The frontend part is ready from my perspective. |
🎉 🎉 🎉 Will do a frontend release tomorrow that includes humidifier support. |
Can't wait till winter... |
Description:
As per discussion in home-assistant/architecture#288, this is the pull request to add an integration for humidifier and dehumidifier devices, which are the consumer devices whose main purpose is to add or remove moisture from the air.
Once this PR is reviewed and merged, I will also raise separate pull requests for
generic_hygrostat
platform and for thehumidity
devices support indemo
,emulated_hue
,prometheus
,homekit
. andgoogle_assistant
integrations. However if you prefer I can combine it all in one PR.Related issue (if applicable): N/A
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11151
Pull request with documentation for developers.home-assistant.io: home-assistant/developers.home-assistant#356
Architecture issue: home-assistant/architecture#310
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.If the code does not interact with devices: