Use "kB" and "s" as UPnP/IGD units #29552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency with various existing components, and they're more commonly used and compact than "kbyte" and "sec".
probot-home-assistant
bot
added
integration: upnp
small-pr
|
Hey there @robbiet480, mind taking a look at this pull request as its been labeled with a integration ( |
|
This is a breaking change for people who keep long records... |
|
Please add a breaking change paragraph in the PR description. |
|
Added. I'm not sure about the extent of the breakage, so didn't try to elaborate on that. Also, have there been changes like this in which previous measurements have been migrated? Should be doable in the states table although maybe a little heavy, and wouldn't affect external databases such as InfluxDB anyway. |
fabaff
approved these changes
Dec 6, 2019
|
I don't know if we have ever done migration of state history in the database. We have migrated the database but only in terms of layout I think. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
UPnP/IGD units of measurement have been aligned with other integrations and common uses, they're now
kBandkB/sinstead ofkbyteandkbyte/secrespectively.Description:
For consistency with various existing components, and they're more
commonly used and compact than "kbyte" and "sec".
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: