Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google assistant local api #30413

Closed
wants to merge 2 commits into from

Conversation

elupus
Copy link
Contributor

@elupus elupus commented Jan 2, 2020

Description:

Support local api execution for google assistant with local install

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@probot-home-assistant
Copy link

Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration (cloud) you are listed as a codeowner for? Thanks!

@probot-home-assistant
Copy link

Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration (google_assistant) you are listed as a codeowner for? Thanks!

@elupus
Copy link
Contributor Author

elupus commented Jan 2, 2020

@balloob started on this somewhat. I will need to mess around with cloud again, to support multiple agent users. So dropping the webhook registration.

Think about it, it might actually be more appropriate to open a separate port for this use. Since the normal http port is exposed to internet, and this access doesn't need that at all.

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Feb 16, 2020
@balloob
Copy link
Member

balloob commented Feb 16, 2020

Locked this PR to members only because I am going to link it in a blog post and I want to avoid random people +1 spamming it.

@elupus
Copy link
Contributor Author

elupus commented Feb 16, 2020

Ok

@elupus
Copy link
Contributor Author

elupus commented Feb 16, 2020

I just rebased it. Will try got some more time to spend on it.

@frenck
Copy link
Member

frenck commented Nov 20, 2020

This PR has been running stale for a while now. Closing it up, for now, feel free to re-open when ready to work on it again.

@frenck frenck closed this Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants