Add Abode water valve support

[shred86]

Description:

Add support for water valves in Abode. Unfortunately, I don't have a water valve to test so I'll need someone else to test this.

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the [development checklist][dev-checklist]

[jbbarnes77]

I can assist with that. I have a Home Assistant setup and a Dome water valve and am glad to test.

[shred86]

Awesome! Are you just able to run the Abode integration as a custom component with this changed file? The water valve should show up and just appear as a switch.

[springstan]

@jbbarnes77 any updates on testing this addition? :)

[jbbarnes77]

Hi. Just got my Dome valve installed the other day. Needed a plumber to remove my rotating shutoff valve with a quarter-turn valve. It is now operational from within Abode.

I have installed a HA Docker container on my Synology NAS and connected to my Abode system. It shows all the devices that were present BEFORE I added the Dome shutoff valve and I haven't been able to refresh it successfully. Could you instruct me on how to do that?

Below is a screenshot of my current devices.

@jbbarnes77 any updates on testing this addition? :)

[shred86]

I’m not quite sure what you mean. Are you saying you added or removed other Abode devices besides the Dome shutoff valve?

You won’t see the Dome shutoff valve unless you run the Abode integration as a custom component in Home Assistant with the changes in this pull request.

[jbbarnes77]

Yes, that's what I meant. That i didn't see the Dome valve at all within HA once adding it. I first connected it with my SmartThings hub, but Abode didn't see it. I reset the Dome valve and then added it as a new device within the Abode web interface. At that point I was able to open it, close it, and create Cue automations successfully.

So at this point I'm just looking for your guidance in what I need to do to test and give you the feedback you need. I'm afraid I have no experience with HA at all besides installing the Docker container and integrating it with a few accounts such as IFTTT, LIFX, Kasa and Abode.

[shred86]

Do you have access to the Home Assistant config folder? If so, it's fairly straight forward to run custom component. From the config folder, create a folder called custom_components and unzip this file such that the abode folder is inside custom_components directory. The directory path should look like config/custom_components/abode.

https://drive.google.com/open?id=1cTCLSLsVzqME3EmYKB3Y0lDw_jnl8-qg

That file is the abode component but with the changes I made to the switch.py file. Once that's done, restart Home Assistant and now it should load the Abode component from that custom components directory. If everything worked correctly, you should now see the Dome water valve show up as a switch.

[springstan]

@jbbarnes77 have you successfully tested this addition? :)

[springstan]

@shred86 the documentation will need to be updated as well, therefore I have added the docs-missing label. Could you please open a PR for that? Thanks 👍

@jbbarnes77 do you need any help testing this new addition? We can assist you if you want to :)

[shred86]

Will do. I also sent a message to @jbbarnes77 on this Reddit thread.

[shred86]

PR made for the documentation: home-assistant/home-assistant.io#11954

[springstan]

@shred86 thanks for updating the docs! 👍

[springstan]

@shred86 do you want to wait for user validation before we merge this?

[shred86]

I don’t think it’s required. I’m about 99.9% sure this fixes the issue. However, I made another larger PR #31514 that will conflict with this one. Would it be easier to close this PR and I just make the changes in the other PR, or wait until after the other one is merged and rebase this one?

[springstan]

Why not merge this one and rebase #31514 to include these changes?

[shred86]

Honestly, I’m just a Git newb and rebasing scares me lol. That should work, I’m sure I’ll figure it out. ;)

[springstan]

I am sure too! 👍

[jbbarnes77]

I am off this morning and can test the integration if someone wants to walk me through it. I can also do a TeamViewer session if there is much involved in setting it up. I am running a Home Assistant Docker container on my Synology, Abode 1st Gen with 50+ sensors, and a Dome valve.

…

On 2/8/2020 6:54 AM, shred86 wrote: Honestly, I’m just a Git newb and rebasing scares me lol. That should work, I’m sure I’ll figure it out. ;) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#30635>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIMNU6D4RVP26CG65BJFFMDRB3IR7ANCNFSM4KFCEFWQ>.

[shred86]

@jbbarnes77 If you're in the Home Assistant discord, I can walk you through setting up a custom component to test these changes plus some others. My username in there is shred.