Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gen_requirements_all.py case insensitive for ignored packages #30885

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Make gen_requirements_all.py case insensitive for ignored packages #30885

merged 1 commit into from
Mar 5, 2020

Conversation

belidzs
Copy link
Contributor

@belidzs belidzs commented Jan 17, 2020

Description:

When I was working on implementing a new platform I have added RPi.GPIO to the requirements. It turns out this was actually a blacklisted component in gen_all_requirements.py but because I have accidentally wrote RPI.GPIO instead (same component, different case) it got added to requirements_all.txt anyway.

This caused pylint to fail on a completely different, but already approved component in the dev branch (rpi_gpio). Since it took a while to track down this problem I figured I might as well fix gen_requirements_all.py to ignore case when matching against blacklisted packages.

Related issue (if applicable): #30837

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@probot-home-assistant probot-home-assistant bot added the small-pr PRs with less than 30 lines. label Jan 17, 2020
@belidzs belidzs changed the title Make gen_requirements_all.py case unsensitive for ignored packages. Make gen_requirements_all.py case insensitive for ignored packages. Jan 17, 2020
@MartinHjelmare MartinHjelmare changed the title Make gen_requirements_all.py case insensitive for ignored packages. Make gen_requirements_all.py case insensitive for ignored packages Jan 17, 2020
@balloob balloob merged commit 1d3647e into home-assistant:dev Mar 5, 2020
@lock lock bot locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants