Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move program_mode check #31501

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Move program_mode check #31501

merged 1 commit into from
Feb 5, 2020

Conversation

aneisch
Copy link
Contributor

@aneisch aneisch commented Feb 5, 2020

Radiotherm: Don't try to capture program_mode unless ct80

Breaking change

Proposed change

Fix RadioTherm

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
climate:
  platform: radiotherm
  host:
    - 10.0.0.29
  hold_temp: True

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Don't try to capture program_mode unless ct80
@probot-home-assistant probot-home-assistant bot added integration: radiotherm small-pr PRs with less than 30 lines. labels Feb 5, 2020
@balloob balloob added this to the 0.105.1 milestone Feb 5, 2020
@balloob balloob merged commit c9be201 into home-assistant:dev Feb 5, 2020
balloob pushed a commit that referenced this pull request Feb 5, 2020
Don't try to capture program_mode unless ct80
@balloob balloob mentioned this pull request Feb 5, 2020
@dseven
Copy link
Contributor

dseven commented Feb 6, 2020

Thanks for fixing this!

A request for future; please mention "radiotherm" in the issue. I almost submitted a dup because issue search didn't find anything. I stumbled on this by looking at commit history on the code (intending to try to figure out what broke it).

@lock lock bot locked and limited conversation to collaborators Feb 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Radiotherm KeyError
4 participants