Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use min and m as units in Garmin Connect for consistency and correctness #31543

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Use min and m as units in Garmin Connect for consistency and correctness #31543

merged 1 commit into from
Feb 6, 2020

Conversation

scop
Copy link
Member

@scop scop commented Feb 6, 2020

Proposed change

"m" is a proper, official acronym for meters, and "min" is used in other integrations for minutes instead of the fully expanded name. Consistency and familiarity.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link

Hey there @cyberjunky, mind taking a look at this pull request as its been labeled with a integration (garmin_connect) you are listed as a codeowner for? Thanks!

@balloob balloob added this to the 0.105.2 milestone Feb 6, 2020
@balloob balloob merged commit 08a74ff into home-assistant:dev Feb 6, 2020
@balloob balloob mentioned this pull request Feb 6, 2020
@lock lock bot locked and limited conversation to collaborators Feb 8, 2020
@scop scop deleted the garmin-connect-units branch February 8, 2020 19:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants