Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vicare water_heater set_temperature fix and bump PyVicare to 0.1.7 #31672

Merged
merged 2 commits into from Feb 10, 2020

Conversation

oischinger
Copy link
Contributor

@oischinger oischinger commented Feb 9, 2020

Proposed change

This fixes a obvious but undiscovered bug in the water heater component:
Instead of the commanded value the previous value was set on the API

Also the PyVicare API is updated to the latest version

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

This fixes a obvious but undiscovered bug in the water heater component:
Instead of the commanded value the prvious value was set on the API
@probot-home-assistant probot-home-assistant bot added integration: vicare small-pr PRs with less than 30 lines. labels Feb 9, 2020
@project-bot project-bot bot added this to Needs review in Dev Feb 9, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 9, 2020
@springstan
Copy link
Member

@oischinger please run python3 -m script.gen_requirements_all inside of your dev environment to solve the validate error ✌

Copy link
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Dev automation moved this from By Code Owner to Reviewer approved Feb 9, 2020
@springstan springstan merged commit 7e0560c into home-assistant:dev Feb 10, 2020
Dev automation moved this from Reviewer approved to Done Feb 10, 2020
@lock lock bot locked and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants