Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize RainMachine config flow #32131

Merged
merged 2 commits into from
Feb 24, 2020

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Feb 24, 2020

Proposed change

This PR modernizes the RainMachine config flow:

  • Removes OrderedDict usage (no longer needed)
  • Uses built-in unique ID and abort helpers (instead of custom logic)
  • Registers the domain upon config flow definition

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
simplisafe:
  accounts:
    - username: !secret simplisafe_username
      password: !secret simplisafe_password

Additional information

  • This PR fixes or closes issue: N/A
  • This PR is related to issue: N/A
  • Link to documentation pull request: N/A

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #32131 into dev will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #32131      +/-   ##
==========================================
- Coverage   94.74%   94.74%   -0.01%     
==========================================
  Files         767      767              
  Lines       55498    55493       -5     
==========================================
- Hits        52581    52575       -6     
- Misses       2917     2918       +1
Impacted Files Coverage Δ
...omeassistant/components/rainmachine/config_flow.py 97.05% <100%> (-0.38%) ⬇️
homeassistant/components/uk_transport/sensor.py 93.47% <0%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ec7d07...ccdda08. Read the comment docs.

@bachya bachya merged commit edf44f4 into home-assistant:dev Feb 24, 2020
@bachya bachya deleted the rainmachine-config-entry branch February 24, 2020 20:06
@lock lock bot locked and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants