-
-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate homekit_controller .homekit folder #32158
Deprecate homekit_controller .homekit folder #32158
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #32158 +/- ##
==========================================
+ Coverage 94.74% 94.75% +0.01%
==========================================
Files 767 768 +1
Lines 55621 55644 +23
==========================================
+ Hits 52696 52727 +31
+ Misses 2925 2917 -8
Continue to review full report at Codecov.
|
OK - changes made. Release set to 0.109.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please mention the time plan in the breaking changes paragraph.
@MartinHjelmare i tweaked it a bit and mentioned the target release - how is that? |
Great! |
Breaking change
Support for homekit_controller's legacy pairing data folder
.homekit
has been deprecated. This has not been how pairings are saved since Home Assistant 0.94. In 0.109.0 we plan to remove this code. If you are running Home Assistant 0.94 or later this does not affect you - your pairings were already migrated to config entries. If you are running an older release and do not upgrade soon you will not be able to automatically migrate your existing pairings at upgrade time and will have to manually re-pair them.Proposed change
Home Assistant currently tries to load pairing information from the
.homekit
folder when it sees a device that is paired but doesn't have a config entry. The is compatibility code from before homekit_controller supported config entries, and its been there for just under a year. I would like to deprecate it and then remove it after a couple of releases to simplify the code a bit.Anyone running Home Assistant from after May 2019 would be unaffected as their .homekit folder will already be migrated. This would only affect people migrating from Home Assistant of that age directly to a version where support has been removed. The would have to repair their accessories via config flow.
CC @MartinHjelmare as discussed in #32141
Type of change
Additional information
Checklist
black --fast homeassistant tests
)The integration reached or maintains the following Integration Quality Scale: